Skip to content

[TEST] Code cleanup in exporter tests#4158

Open
marcalff wants to merge 5 commits into
open-telemetry:mainfrom
marcalff:fix_test_cleanup
Open

[TEST] Code cleanup in exporter tests#4158
marcalff wants to merge 5 commits into
open-telemetry:mainfrom
marcalff:fix_test_cleanup

Conversation

@marcalff

@marcalff marcalff commented Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes # (issue)

Issue

Exporter unit tests contain:

#ifndef OPENTELEMETRY_STL_VERSION

This:

  • disable the tests in CI, typically run without a specific STL
  • disable include-what-you-use

Changes

Please provide a brief description of the changes here.

  • Removed the test on OPENTELEMETRY_STL_VERSION.
    • This was an old work around for an issue in GMock. The work around is no longer necessary.
  • Applied clang-format to the code
  • Resolved all issues reported by include-what-you-use

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov

codecov Bot commented Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.78%. Comparing base (5c60fa8) to head (ace30cd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4158      +/-   ##
==========================================
- Coverage   82.80%   82.78%   -0.01%     
==========================================
  Files         415      415              
  Lines       17450    17450              
==========================================
- Hits        14447    14445       -2     
- Misses       3003     3005       +2
Files with missing lines Coverage Δ
exporters/otlp/src/otlp_grpc_exporter_factory.cc 50.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff marked this pull request as ready for review July 10, 2026 20:25
@marcalff marcalff requested a review from a team as a code owner July 10, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@marcalff